Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin nightly to 2024-05-04 due to recently-enabled check-cfg #1109

Closed
wants to merge 3 commits into from
Closed

Pin nightly to 2024-05-04 due to recently-enabled check-cfg #1109

wants to merge 3 commits into from

Conversation

ryoqun
Copy link
Contributor

@ryoqun ryoqun commented May 15, 2024 •
edited
Loading

I'm jumping on this workaround in #1040 (comment) in desperation of shipping select_biased!, assuming build.rs isn't a viable option (as concerns is raised upstream: rust-lang/rust#124800)....:

Maybe pinning to older nightly (nightly-2024-05-04 or earlier according to https://blog.rust-lang.org/2024/05/06/check-cfg.html) in crossbeam CI isn't a viable option?

@ryoqun ryoqun marked this pull request as ready for review May 15, 2024 02:43
@ryoqun
Copy link
Contributor Author

ryoqun commented May 15, 2024 •
edited
Loading

@taiki-e could you review this?

fyi, you can see ci builds as if these changes were on the master branch here: https://github.com/ryoqun/crossbeam/actions/runs/9089208830 (That's why I'm creating this pr from my fork's master branch). it seems that cirrus ci isn't run there understandably..

@ryoqun ryoqun changed the title [wip] Pin nightly Pin nightly to 2024-05-04 due to overly restrictive cfg check May 15, 2024
@ryoqun ryoqun changed the title Pin nightly to 2024-05-04 due to overly restrictive cfg check Pin nightly to 2024-05-04 due to recently-added cfg check May 15, 2024
@ryoqun ryoqun changed the title Pin nightly to 2024-05-04 due to recently-added cfg check Pin nightly to 2024-05-04 due to recently-added check-cfg May 15, 2024
@ryoqun ryoqun mentioned this pull request May 15, 2024
Merged
@ryoqun ryoqun changed the title Pin nightly to 2024-05-04 due to recently-added check-cfg Pin nightly to 2024-05-04 due to recently-enabled check-cfg May 15, 2024
@taiki-e
Copy link
Member

taiki-e commented May 19, 2024

Thanks for the PR! I would like to use rust-lang/cargo#13913 's config option instead if possible.

@ryoqun
Copy link
Contributor Author

ryoqun commented May 19, 2024

Thanks for the PR! I would like to use rust-lang/cargo#13913 's config option instead if possible.

@taiki-e seems rust-lang/cargo#13913 is synced to the rustc repo and nightly-2024-05-19 contains it. Although, the diagnostics aren't updated yet (rust-lang/rust#125219), I'll soon open another pr. so closing this now.

@ryoqun ryoqun closed this May 19, 2024
@ryoqun ryoqun mentioned this pull request May 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryoqun @taiki-e